Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Kubernetes example for custom node modules #17848

Merged
merged 4 commits into from
Jul 30, 2024
Merged

docs: Kubernetes example for custom node modules #17848

merged 4 commits into from
Jul 30, 2024

Conversation

keegoid-nr
Copy link
Contributor

  • add EFS + EKS example detailing how to copy custom modules to a PV prior to launching the SJM
  • fix yaml parameter names

@keegoid-nr
docs: Kubernetes example for custom node modules
367bf90 
add EFS + EKS example detailing how to copy custom modules to a PV prior to launching the SJM
@keegoid-nr keegoid-nr marked this pull request as draft June 29, 2024 18:23
@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Jun 29, 2024
@github-actions GitHub Actions
Copy link

Hi @keegoid-nr 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

@netlify Netlify
Copy link

netlify bot commented Jun 29, 2024 •
edited

✅ Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit f9a7734
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/66a825d3b933dc000710e5e7
😎 Deploy Preview https://deploy-preview-17848--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@keegoid-nr
Copy link
Contributor Author

@bpeckNR - I'd love a review of this draft.

@jeff-colucci jeff-colucci moved this from Hero to triage to Drafts in Docs PRs and Issues Jul 1, 2024
@keegoid-nr
Copy link
Contributor Author

@jeff-colucci We are ready to merge this PR.

@keegoid-nr keegoid-nr marked this pull request as ready for review July 26, 2024 19:46
@rhetoric101 rhetoric101 moved this from Drafts to Hero to triage in Docs PRs and Issues Jul 26, 2024
@rhetoric101 rhetoric101 added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Jul 26, 2024
@ally-sassman ally-sassman moved this from Hero to triage to Waiting on TW to merge in Docs PRs and Issues Jul 29, 2024
jeff-colucci
jeff-colucci reviewed Jul 29, 2024
View reviewed changes
...content/docs/synthetics/synthetic-monitoring/private-locations/job-manager-configuration.mdx Outdated
```

### Create `mount-custom-mods-pod` to copy your custom-modules directory

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a step 1 or some sort of direction here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeff-colucci. It could be like:

Custom-modules directory

  1. Create mount-custom-mods-pod to copy your custom-modules directory

@jeff-colucci
Copy link
Contributor

@keegoid-nr There's some funky-ness going on with the numbering not working correctly, I believe I've fixed it and I will keep an eye on it when it builds. In the meantime, there seems to be a missing step 1 text, which I highlighted above. Once that is fixed and the indentation issues in the MDX file are confirmed to be working, we can push this out!

@ally-sassman ally-sassman merged commit c2b6431 into newrelic:develop Jul 30, 2024
17 checks passed
@keegoid-nr
Copy link
Contributor Author

@jeff-colucci Looks like this part got messed up a bit. It should be a code block.
image

@keegoid-nr
Copy link
Contributor Author

@jeff-colucci The example should be indented so the numbered items can go from 1 to 2 intead of 1 to 1.
image

@keegoid-nr
Copy link
Contributor Author

keegoid-nr commented Aug 6, 2024 •
edited

This section should not be indented so the numbering can start from 1 again.
image

Same for this one.
image

@keegoid-nr
Copy link
Contributor Author

This log message is no longer valid for the SJM (it was for the CPM).
image

@keegoid-nr
Copy link
Contributor Author

keegoid-nr commented Aug 6, 2024 •
edited

@jeff-colucci I'll create a new PR with these fixes.
#18280
I'd love to learn how to preview changes in VS Code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-colucci jeff-colucci jeff-colucci left review comments

@ally-sassman ally-sassman ally-sassman approved these changes

Assignees

@jeff-colucci jeff-colucci

Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
Docs PRs and Issues
Archived in project
Docs PRs and Issues
Waiting on TW to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@keegoid-nr @jeff-colucci @ally-sassman @rhetoric101 @tabathadelane